NAS-131378 / 25.04 / Fangtooth iSCSI service data-test tag of the Running toggle is inconsistent with the other iSCSI toggle. #10762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is inconsistent with the other iSCSI toggle.
AlexKarpov98
requested review from
RehanY147
and removed request for
a team
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10762 +/- ##
=======================================
Coverage 80.29% 80.29%
=======================================
Files 1571 1571
Lines 51708 51711 +3
Branches 5838 5838
=======================================
+ Hits 41519 41522 +3
Misses 10189 10189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RehanY147
approved these changes
Sep 27, 2024
| @@ -33,6 +34,10 @@ export class ServiceStateColumnComponent extends ColumnComponent<ServiceRow> { | |||
|
|
|||
| protected readonly isRunning = computed(() => this.service().state === ServiceStatus.Running); | |||
|
|
|||
| get testIdServiceName(): string { | |||
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: see ticket