Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132272 / 24.10.1 / Update Truecloud backup exclude tooltip (by denysbutenko) #11048

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x d979eca3f8c50e511c482e340d6f4908bf5b046f

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 1c69bf6c033a004390ccf65c58f1e443e8f5f17b

Changes:

Update exclude tooltip for TrueCloud form

Testing:

Code review only

Downstream

Affects Reasoning
Documentation Tooltip text is changed

Original PR: #11016
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132272

@denysbutenko denysbutenko marked this pull request as ready for review November 16, 2024 08:26
@denysbutenko denysbutenko requested a review from a team as a code owner November 16, 2024 08:26
@denysbutenko denysbutenko requested review from undsoft and removed request for a team November 16, 2024 08:26
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@65a454a). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11048   +/-   ##
=====================================================
  Coverage                      ?   79.98%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51438           
  Branches                      ?     5938           
=====================================================
  Hits                          ?    41144           
  Misses                        ?    10294           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko denysbutenko merged commit e3c9dc2 into stable/electriceel Nov 16, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-132272-24.10.1 branch November 16, 2024 09:03
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants