refactor classes

[dfguerrerom]

@trungleduc sorry for the mess... I was expecting first merge this in my fork, yesterday I think both of us were working in the same thing.

In this PR I have used yours as base and have done some editions.

• Create a single initEcharts which will setOptions based on the _createOptionDict.
• I also set the option to listen changes in the rawWidget , what do you think?
• I added the theme as another parameter, it will be used only if users set this parameter in the charts or if they modify it directly, otherwise the themeManager will be used as before.
• I haven't fully tested the other properties

Screencast.from.30-09-2024.12.45.33.webm

This is a WIP

[trungleduc]

Hey, thank you for opening the PR. Maybe it is a duplication with #14 ?

[trungleduc]

Let me merge #14 then you can rebase your PR on top of it?

[dfguerrerom]

Hey, thank you for opening the PR. Maybe it is a duplication with #14 ?

hey, sorry, I was supposed to test it first in my branch but I selected the wrong base branch....
Actually this extends #14... the PR is done on that branch...

[trungleduc]

Merged, let's target main now

[trungleduc]

No problem at all. I will add support for events and actions in a few days

[dfguerrerom]

@trungleduc I have converted this PR as a draft, I think something went wrong with the merge... let me figure it out and I'll ask your review!

[dfguerrerom]

In my last commits I have also added the height and width options... If users set those properties, the default css classes won't be applied, otherwise the default will be used, what do you think?

• I couldn't see the effect of 'useDirtyRect`, do you know if there's a reason for that?
• I'm not very sure about how to define the default values for the properties in the baseWidgetModel, is it fine just let them as null in both sides?

[trungleduc]

Thanks! it looks neat. I will add example and documentation later

[dfguerrerom]

I have tested the trait changes and they work well... However, there's an error when the 'svg' renderer is set and width/height are not a number... I think it is harmless because the class applied to the element will be set in the end, what do you think?

[trungleduc]

I have tested the trait changes and they work well... However, there's an error when the 'svg' renderer is set and width/height are not a number... I think it is harmless because the class applied to the element will be set in the end, what do you think?

The chart size is still correct?

[dfguerrerom]

I have tested the trait changes and they work well... However, there's an error when the 'svg' renderer is set and width/height are not a number... I think it is harmless because the class applied to the element will be set in the end, what do you think?

The chart size is still correct?

if you pass auto/null to height/width, the default .css rule is applied, and therefore, the chart is displayed correctly.

If you pass a valid pixel value, i.e., '200', '200px', it removes the default class and instead, it correctly passes those properties to the init and there's no error.

[trungleduc]

ok so it's good for me

[trungleduc]

Thanks!