Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA label to social media icons on truss.works #3

Open
xtine opened this issue Apr 20, 2020 · 1 comment
Open

Add ARIA label to social media icons on truss.works #3

xtine opened this issue Apr 20, 2020 · 1 comment
Labels
BLOCKED Issue is blocked from moving further. Check comments. bug Something isn't working help wanted Extra attention is needed pivotal import Imported stories from Reserve Pivotal Tracker board

Comments

@xtine
Copy link
Contributor

xtine commented Apr 20, 2020

Issue 7: Social media icons in footer and contact us need label.
Our social media icons need labels on their links so that screen readers know what they are. Right now, screen readers are reading all three as “Link, Trussworks”, so it’s unknown to users who use screen readers that it is a social media link.
Doc with all documented accessibility issues:
https://docs.google.com/document/d/1upM9ue4UAuJwIBbZ6fRdjGKmzs-odcWxDQfYftIrHyw/edit?usp=sharing

PT IMPORTED STORY: https://www.pivotaltracker.com/story/show/171138668

@xtine xtine added the pivotal import Imported stories from Reserve Pivotal Tracker board label Apr 20, 2020
@xtine xtine added the bug Something isn't working label Apr 20, 2020
@xtine
Copy link
Contributor Author

xtine commented Apr 23, 2020

This is proving to be much more difficult than it seems. Because we cannot edit HTML or have control of classes or attributes for social media links, I tried to set the attribute manually via Code Injection in the footer. However, even setting

window.Squarespace.onInitialize(Y, function(){
 document.querySelector("[href='https://twitter.com/truss_works']").setAttribute('aria-label', 'Trussworks Twitter');
});

to just target the Twitter link, it does not seem to have any affect on production.

Upon inspection of the source code, it seems that there is some after body loading scripting of the social media link SVG icons that may reset the attribute setting.

I'm not sure how to proceed in fixing this unless we flip the entire site to edit HTML which then we may lose easier thematic editing in the Squarespace UI.

@xtine xtine added help wanted Extra attention is needed BLOCKED Issue is blocked from moving further. Check comments. labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Issue is blocked from moving further. Check comments. bug Something isn't working help wanted Extra attention is needed pivotal import Imported stories from Reserve Pivotal Tracker board
Projects
None yet
Development

No branches or pull requests

1 participant