Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB version of get_purl does not precent encode values #1113

Closed
ctron opened this issue Dec 18, 2024 · 1 comment
Closed

DB version of get_purl does not precent encode values #1113

ctron opened this issue Dec 18, 2024 · 1 comment
Assignees
@ctron
Labels
bug Something isn't working

Comments

@ctron
Copy link
Contributor

ctron commented Dec 18, 2024

Test case:

assertion `left == right` failed
  left: Some("pkg:maven/org.foo.bar/[email protected]?key=value=value")
 right: Some("pkg:maven/org.foo.bar/[email protected]?key=value%3Dvalue")

Spec:

https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst#rules-for-each-purl-component

A value must be a percent-encoded string
@ctron ctron added the bug Something isn't working label Dec 18, 2024
@ctron ctron self-assigned this Dec 18, 2024
@ctron ctron added this to Trustify Dec 18, 2024
@ctron
Copy link
Contributor Author

ctron commented Jan 13, 2025

Fixed by #1116

@ctron ctron closed this as completed Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Done in Trustify Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctron ctron

Labels
bug Something isn't working
Projects
Trustify
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctron