Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust]: Optimize Rust steps on CI #3044

Open
2 tasks
satoshiotomakan opened this issue Mar 31, 2023 · 0 comments
Open
2 tasks

[Rust]: Optimize Rust steps on CI #3044

satoshiotomakan opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@satoshiotomakan
Copy link
Collaborator

satoshiotomakan commented Mar 31, 2023

Is your feature request related to a problem? Please describe.

At this moment, tools/rust-bindgen builds the Rust library for multiple targets even though they are not required.
For example, there is no need to build Rust library for Android on ios-ci workflow:

if [[ `uname` == "Darwin" ]]; then
echo "Generating Android targets"
cargo build --target aarch64-linux-android --target armv7-linux-androideabi --target x86_64-linux-android --target i686-linux-android --release

Describe the solution you'd like

We can extend the number of possible input arguments for tools/rust-bindgen and tools/install-rust-dependencies with:

  • android - install only android toolchains, build Rust lib for android targets only.
  • ios - install only iOS toolchains, build Rust lib for iOS targets only.
  • wasm - install only WASM toolchain, build Rust lib for WASM target only.
  • native - build Rust lib for native target only.
  • No arguments - install all possible toolchains, build Rust lib for all targets.

Checklist

  • Refactor tools/rust-bindgen and tools/install-rust-dependencies
  • Consider using sccache for all pipelines.
@satoshiotomakan satoshiotomakan added the enhancement New feature or request label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@satoshiotomakan and others