Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Extract Laravel implementation to a separate repository #30

Open
slashequip opened this issue Jan 28, 2022 · 5 comments
Open

Comments

@slashequip
Copy link
Contributor

I would like to propose the the Laravel code is removed from this repository and moved to it's own separate repository.

trycourier/courier-php

  • This allows this package to purely support the PHP implementation.
  • Folks installing the package may not need the the additional code, nor should it be a requirement for them.
  • The current Laravel code is not tested, adding tests would add complexity to this package.
  • IMO, the current Laravel code is well below par when it comes to what the Laravel community expect from a package.
  • Increasing Laravel support here would make it harder for others, unfamiliar with Laravel, to contribute, and understand.

trycourier/courier-laravel

  • Allows improvements to the existing code in a dedicated and well tested environment.
  • Would pull in this package so core functionality is still provided here.
  • The aforementioned environment would allow us to more easily add some more features. I have been thinking about adding the ability to have Courier as a custom notification channel, allowing integration with Laravel's first-party notification system.

Imagine;

$user->notify(new InvoicePaid($invoice));
// Triggers a sendNotification() call to courier with the user reference and additional profile data etc. 🤤
@slashequip
Copy link
Contributor Author

Feel free to tell me to stop 😂

@slashequip
Copy link
Contributor Author

I'll look to put together an example repository together under my GitHub account, see what you think and we can discuss moving forward 😄

@tk26
Copy link
Contributor

tk26 commented Jan 28, 2022

@slashequip apologies I haven't been able to go deep on this proposal just yet. Will def get back later today :)

@slashequip
Copy link
Contributor Author

Don't worry about it, began to put a few things together here; https://github.com/slashequip/courier-laravel/ to replicate existing features and I'll begin to play around with the idea of this notification.

Even if this isn't something Courier wants to own/maintain the package should have merit on it's own anyway.

@tk26
Copy link
Contributor

tk26 commented Feb 2, 2022

sounds good, thanks @slashequip 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants