Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask names #900

Closed
wants to merge 3 commits into from
Closed

Mask names #900

wants to merge 3 commits into from

Conversation

benjeffery
Copy link
Member

Fixes #898
Stacked on #899

Copy link
Contributor

mergify bot commented Feb 7, 2024

⚠️ The sha of the head commit of this PR conflicts with #899. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b9099a) 87.04% compared to head (15267b7) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files           5        5           
  Lines        1767     1767           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        140      140           
  Partials       89       89           
Flag Coverage Δ
C 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot mentioned this pull request Apr 25, 2024
@benjeffery
Copy link
Member Author

Rolled into #896

@benjeffery benjeffery closed this Apr 25, 2024
@benjeffery benjeffery deleted the mask-names branch May 7, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow names of sample and variant maskes to be specified.
1 participant