Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttyd doesn't check client certification when connecting to ip addr instead of domain #1405

Open
ikicha opened this issue Nov 1, 2024 · 1 comment
Labels

Comments

@ikicha
Copy link

ikicha commented Nov 1, 2024

Describe the bug
ttyd doesn't check client certification when connecting to ip addr instead of domain

To Reproduce
Steps to reproduce the behavior:

  1. /ttyd.x86_64 --ssl --ssl-cert server.crt --ssl-key server.key --ssl-ca ca.crt bash
  2. curl --insecure -vvv https://127.0.0.1:7681 succeeds to get response, while curl --insecure -vvv https://localhost:7681 fails.

Expected behavior
It should check and verify the client certificate regardless of how a user connects to ttyd.

Additional context
Here is warmcat/libwebsockets#3257 which is my PR to fix this bug in libwebsockets.
Can we use libwebsockets with patch? or it looks like the recent libwebsocket might include some workaround as well(warmcat/libwebsockets#2902)

@ikicha ikicha added the bug label Nov 1, 2024
@ikicha
Copy link
Author

ikicha commented Nov 11, 2024

the change in libwebsockets has been merged in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant