From f83c0c557e845f1ef7c83d493192b06b0d25c316 Mon Sep 17 00:00:00 2001
From: ttys0dev <126845556+ttys0dev@users.noreply.github.com>
Date: Thu, 3 Oct 2024 17:43:08 -0600
Subject: [PATCH] Fix setDefaultOptions in updateToolbarButton

---
 src/utils/toolbar_button.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/utils/toolbar_button.js b/src/utils/toolbar_button.js
index cf94452b..a8bf12c2 100644
--- a/src/utils/toolbar_button.js
+++ b/src/utils/toolbar_button.js
@@ -31,6 +31,13 @@ export function updateToolbarButton(tab) {
   };
 
   chrome.storage.local.get('options', function (items) {
+    if (!Object.keys(items).length) {
+      // Firefox 56 bug. The default settings didn't get created properly when
+      // upgrading from the legacy extension. This can be removed when everybody
+      // is safely beyond 56 (and the ESR)
+      setDefaultOptions({});
+    }
+
     if (
       'dismiss_news_badge' in items['options'] &&
       items['options']['dismiss_news_badge']
@@ -52,12 +59,6 @@ export function updateToolbarButton(tab) {
       });
       return;
     }
-    if (!Object.keys(items).length) {
-      // Firefox 56 bug. The default settings didn't get created properly when
-      // upgrading from the legacy extension. This can be removed when everybody
-      // is safely beyond 56 (and the ESR)
-      setDefaultOptions({});
-    }
 
     if (items && items['options'] && !items['options']['recap_enabled']) {
       setTitleIcon('RECAP is temporarily disabled', {