From 0f6ae5809f888e79d7f7304c49caf3cc38311d92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9C=D0=B0=D0=BB=D0=B0=D1=85=D0=BE=D0=B2=20=D0=90=D0=BB?= =?UTF-8?q?=D0=B5=D0=BA=D1=81=D0=B5=D0=B9=20=D0=9F=D0=B0=D0=B2=D0=BB=D0=BE?= =?UTF-8?q?=D0=B2=D0=B8=D1=87?= Date: Thu, 12 Sep 2024 13:25:52 +0000 Subject: [PATCH] move back to mixin --- turbo_alignment/common/logging/__init__.py | 2 +- turbo_alignment/{common/logging => pipelines/mixin}/logging.py | 2 +- turbo_alignment/pipelines/train/base.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename turbo_alignment/{common/logging => pipelines/mixin}/logging.py (97%) diff --git a/turbo_alignment/common/logging/__init__.py b/turbo_alignment/common/logging/__init__.py index dd97883..10a133c 100755 --- a/turbo_alignment/common/logging/__init__.py +++ b/turbo_alignment/common/logging/__init__.py @@ -1,2 +1,2 @@ +from ...pipelines.mixin.logging import LoggingRegistry from .logger import get_project_logger -from .logging import LoggingRegistry diff --git a/turbo_alignment/common/logging/logging.py b/turbo_alignment/pipelines/mixin/logging.py similarity index 97% rename from turbo_alignment/common/logging/logging.py rename to turbo_alignment/pipelines/mixin/logging.py index 86ec367..a95ae00 100755 --- a/turbo_alignment/common/logging/logging.py +++ b/turbo_alignment/pipelines/mixin/logging.py @@ -35,7 +35,7 @@ def get_logging_callback(experiment_settings: BaseTrainExperimentSettings) -> Wa @LoggingRegistry.register(ClearMLSettings.__name__) -class ClearMLLogging(LoggingMixin): +class ClearMLLoggingMixin(LoggingMixin): @staticmethod def get_logging_callback(experiment_settings: BaseTrainExperimentSettings) -> ClearMLLoggingCallback: logging_settings: ClearMLSettings = ClearMLSettings(**experiment_settings.logging_settings.dict()) diff --git a/turbo_alignment/pipelines/train/base.py b/turbo_alignment/pipelines/train/base.py index bbe68a3..0f98602 100755 --- a/turbo_alignment/pipelines/train/base.py +++ b/turbo_alignment/pipelines/train/base.py @@ -15,13 +15,13 @@ from turbo_alignment.cherry_picks.base import CherryPickCallbackBase from turbo_alignment.common.data.io import write_json from turbo_alignment.common.logging import get_project_logger -from turbo_alignment.common.logging.logging import LoggingRegistry from turbo_alignment.common.tf.loaders.model import load_model from turbo_alignment.common.tf.loaders.tokenizer import load_tokenizer from turbo_alignment.common.tf.special_tokens_setter import SpecialTokensSetter from turbo_alignment.dataset.loader import DatasetLoader from turbo_alignment.pipelines.base import BaseStrategy from turbo_alignment.pipelines.mixin import S3Mixin +from turbo_alignment.pipelines.mixin.logging import LoggingRegistry from turbo_alignment.settings.datasets.base import DatasetStrategy from turbo_alignment.settings.pipelines.train.base import BaseTrainExperimentSettings from turbo_alignment.settings.s3 import ExperimentMetadata, S3HandlerParameters