From 3e002ea451405b197be06707683df3b6e73f9b5a Mon Sep 17 00:00:00 2001 From: "a.khokhulin" Date: Sat, 2 Nov 2024 14:31:59 +0300 Subject: [PATCH 1/3] added output_uri param --- turbo_alignment/common/logging/clearml.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/turbo_alignment/common/logging/clearml.py b/turbo_alignment/common/logging/clearml.py index c429439..bc6abdc 100644 --- a/turbo_alignment/common/logging/clearml.py +++ b/turbo_alignment/common/logging/clearml.py @@ -7,7 +7,7 @@ def create_clearml_task(parameters: ClearMLSettings, config: dict[str, Any] | None = None) -> Task: clearml_task = Task.init( - task_name=parameters.task_name, project_name=parameters.project_name, continue_last_task=True # FIXME? + task_name=parameters.task_name, project_name=parameters.project_name, continue_last_task=True, output_uri=False ) clearml_task.connect_configuration(config, name='HyperParameters') From 3dd202aba02d72ac18a03971e889b595cf0caedd Mon Sep 17 00:00:00 2001 From: "a.khokhulin" Date: Sun, 3 Nov 2024 20:30:40 +0300 Subject: [PATCH 2/3] pretty --- turbo_alignment/common/logging/clearml.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/turbo_alignment/common/logging/clearml.py b/turbo_alignment/common/logging/clearml.py index bc6abdc..1a3e272 100644 --- a/turbo_alignment/common/logging/clearml.py +++ b/turbo_alignment/common/logging/clearml.py @@ -7,7 +7,10 @@ def create_clearml_task(parameters: ClearMLSettings, config: dict[str, Any] | None = None) -> Task: clearml_task = Task.init( - task_name=parameters.task_name, project_name=parameters.project_name, continue_last_task=True, output_uri=False + task_name=parameters.task_name, + project_name=parameters.project_name, + continue_last_task=True, + output_uri=False, ) clearml_task.connect_configuration(config, name='HyperParameters') From 9e987127113d83ea949d5bfcfb8b07aa23ed80f6 Mon Sep 17 00:00:00 2001 From: "a.khokhulin" Date: Sun, 3 Nov 2024 20:42:51 +0300 Subject: [PATCH 3/3] linters fix --- turbo_alignment/common/tf/callbacks/logging.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/turbo_alignment/common/tf/callbacks/logging.py b/turbo_alignment/common/tf/callbacks/logging.py index c72ebc6..8f90288 100755 --- a/turbo_alignment/common/tf/callbacks/logging.py +++ b/turbo_alignment/common/tf/callbacks/logging.py @@ -70,10 +70,7 @@ def _log(self, logs: dict[str, Any], state: TrainerState) -> None: self._wandb_run.log({**rewritten_logs, 'train/global_step': state.global_step}, step=state.global_step) def _fix_table_type(self, logs: dict[str, Any]) -> dict[str, Any]: - return { - k: wandb.Table(dataframe=v) if isinstance(v, pd.DataFrame) else v - for k, v in logs.items() - } + return {k: wandb.Table(dataframe=v) if isinstance(v, pd.DataFrame) else v for k, v in logs.items()} class ClearMLLoggingCallback(LoggingCallback):