Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate boto -> boto3 #336

Open
5 tasks
hershaw opened this issue May 29, 2016 · 2 comments
Open
5 tasks

Migrate boto -> boto3 #336

hershaw opened this issue May 29, 2016 · 2 comments

Comments

@hershaw
Copy link
Contributor

hershaw commented May 29, 2016

Info

boto maintenance has staled and although boto is python 3 compatible system-wide boto plugins may not be which can cause an import of SFrame objects to fail at runtime. For example, this will happen on GCE ubuntu machines

boto is used in two places: file_util.py and test_gl_pickler.py

file_util.py is unit tested here

TODO

  • Change setup.py to remove boto and include boto3
  • Migrate file_util.py
    • TODO: spec boto3 api usage
  • Migrate test_gl_picker.py
    • TODO: spec boto3 api usage
@hershaw
Copy link
Contributor Author

hershaw commented May 29, 2016

In my fork I have changed setup.py to use boto3 and then re-built the package:

source oss_local_scripts/python_env.sh debug
cd debug/oss_src/unity/python
make -j 4

But when I try to do an import of boto3 in file_util.py it's not available. Do I need to rebuild the miniconda package or something using the new setup.py?

@TobyRoseman

@TobyRoseman
Copy link
Contributor

@hershaw - Good question. Changes to the setup.py affect the egg/wheel but not dev builds, which is what you're running. To change that, make the same change here: https://github.com/dato-code/SFrame/blob/fac7e34200e9105e9f54ab46d60c12a7643d070b/oss_local_scripts/pip_requirements.txt

Then you'll need to do a configure --cleanup. Then rerun configure and rerun make.

Let me know if you have any more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants