-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getBestRegionHost fails with ArrayIndexOutOfBoundsException #6
Comments
Same here, sadly.
|
Same thing is happening on our systems. |
So anyone with this issue, and I assume thats everyone, needs to change this line https://github.com/turn/splicer/blob/master/src/main/java/com/turn/splicer/hbase/RegionChecker.java#L34, from 4 to 3. Or no matter what splicer will never work. |
We use metric width of 4 in our TSDB installation. AFAIK, this is a configurable parameter in TSDB. We could do the same here. |
@wicknicks I am sorry for the wording, I meant anyone with this issue will not get splicer working without the change. Mainly because I wasn't aware that there was a setting in tsdb to change this, I honestly thought it was some versioning thing. That being said I am definitely +1 on the idea to make this configurable, as I can't imagine changing the metric width in tsdb is simple haha. |
No problem. I will create a pull request with the changes in the few days. |
Faced same issue, my OpenTSDB has default setting http://opentsdb.net/docs/build/html/user_guide/configuration.html
@supernomad's advise didn't help I would be appreciated for any advice |
All good, thanks to gradlew it's fixed. One annoying thing is left, there is no logging anymore.
|
Regarding logging, if it's not set up in your ops environment you can add a Example
|
Thanks @alugowski |
@mancubus77 try adding an additional JVM parameter |
Hi,
we tried splicer today. After building it and setting up the correct firewall permissions for our regionservers it sadly fails when doing a test query:
curl 'http://127.0.0.1:4245/api/query' --data-binary '{"start":1473715620025,"queries":[{"metric":"nine.telegraf.cpu_usage_user","aggregator":"sum","rate":false,"rateOptions":{"counter":false},"downsample":"10m-max","tags":{}}]}' {"error": "java.util.concurrent.ExecutionException: java.lang.ArrayIndexOutOfBoundsException, stacktrace=com.turn.splicer.tsdbutils.SplicerQueryRunner.runQuerySlices(SplicerQueryRunner.java:110), com.turn.splicer.tsdbutils.SplicerQueryRunner.sliceAndRunQuery(SplicerQueryRunner.java:61)"}
I looks like it fails in the end with an "ArrayIndexOutOfBoundsException" in the getBestRegionHost Function:
Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: Caused by: java.lang.ArrayIndexOutOfBoundsException: null Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at java.lang.System.arraycopy(Native Method) ~[na:1.8.0_91] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at com.turn.splicer.hbase.RegionChecker.getBestRegionHost(RegionChecker.java:62) ~[tsdb-splicer-all-0.1.5-2016011901.jar:na] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at com.turn.splicer.HttpWorker.call(HttpWorker.java:71) ~[tsdb-splicer-all-0.1.5-2016011901.jar:na] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at com.turn.splicer.HttpWorker.call(HttpWorker.java:27) ~[tsdb-splicer-all-0.1.5-2016011901.jar:na] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_91] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[na:1.8.0_91] Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[na:1.8.0_91]
The correspnding MetricsCacher seems to get a result though:
Oct 05 17:08:48 metrics-splicer-cz41-1 java[12804]: 2016-10-05 17:08:48,069 INFO [splice-pool-1-thread-0] MetricsCache: Looking up key for metric=nine.telegraf.cpu_usage_user. Found result=[0, 0, 35]
Are we doing anything wrong? Thanks for any help.
The text was updated successfully, but these errors were encountered: