Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload fail after 10min request #576

Closed
orisailes opened this issue Feb 5, 2024 · 3 comments
Closed

Upload fail after 10min request #576

orisailes opened this issue Feb 5, 2024 · 3 comments

Comments

@orisailes
Copy link

First, i am not using the resumable uploads because of this bug.

When my users trying to upload a file for more then 10+- minutes, they are getting an error with status 404. for me it seems like timeout error.
I tried to adjust the req.setTimeout function in the express, but unfortunately with no success. i did change the timeout but it has limitation so i thought it might be a client side timeout, but i cannot change the client side timeout because it is not possible with tus-js-client

Steps to reproduce the behavior:

  1. Use tus-js-client, tus/server and tus/gcs-store
  2. Start upload, use Slow 3G internet upload speed (or lower) to mock a very slow upload
  3. See error after 10.9 minutes

More about the error:
Request timings:
image
Request details:
image
*notice that Keep-Alive:timeout=5 has no role here though its return from the BE side (witch the timeout is controlled properly there.. i guess)

Setup details
Please provide following details, if applicable to your situation:

  • Runtime environment: Google Chrome
  • Versions:
 "@tus/gcs-store": "^1.0.1",
 "@tus/server": "^1.0.1",
 "tus-js-client": "^3.1.3", 
@fenos
Copy link
Collaborator

fenos commented Feb 5, 2024

Hello @orisailes are you able to log the error you are getting with:

const tusServer = new Server({
  ...
  onResponseError: (req, res, err) => {
      console.error(err)
  }
});

That would tell us what the underline timeout / problem could be

@fenos
Copy link
Collaborator

fenos commented Feb 5, 2024

could you also update tus-node-server to the latest version please?
newer versions has received significant improvements

@orisailes
Copy link
Author

Yes! upgrade version solve the problem. wasn't that easy to upgrade it though. i can see that the upload protocol works differently (better!)
FYI: onResponseError does not catching every error from some readon...
thanks alot !! @fenos

@Murderlon Murderlon closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants