Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind with empty password allowed #27

Open
gfargeas opened this issue Jul 6, 2015 · 1 comment
Open

Bind with empty password allowed #27

gfargeas opened this issue Jul 6, 2015 · 1 comment

Comments

@gfargeas
Copy link

gfargeas commented Jul 6, 2015

Hi,
I noticed a worrisome behaviour when using an empty password to log in with your plugin.
The ldapjs authenticate() function does not seem to fail when providing an empty password. This is apparently known and unfortunately an AD legal behaviour.
Refer to ldapjs/node-ldapjs#191 for more information.
If you need more details about this particular behaviour on my setup, let me know.

@xerya
Copy link

xerya commented Jul 8, 2016

I noticed the same with AD as the LDAP directory. I added a simple check for empty password in ep_ldapauth.js function exports.authenticate, after the variable definitions and before LDAP authentication:

if (!password) {
  console.error('ep_ldapauth.authenticate: Empty password!');
  return cb([false]);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants