Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO tracking issue #65

Open
hauntsaninja opened this issue Oct 11, 2022 · 1 comment
Open

TODO tracking issue #65

hauntsaninja opened this issue Oct 11, 2022 · 1 comment

Comments

@hauntsaninja
Copy link
Contributor

From recent PRs, we've accumulated some TODOs in the source code. Putting them in this issue so they're more visible:

  • Use requires_dist for the version spec we want:
    # TODO: PyPI doesn't seem to have version specific requires_dist. This does mean we can be
  • Have some sensible restrictions on which typeshed distributions can depend on other typeshed distributions. This will let us loosen the external allowlist:
    # TODO: make sure that if a typeshed distribution depends on other typeshed stubs,
  • Less hacky support for distributions that aren't on PyPI:
    # TODO: add a field to METADATA.toml if the stubs are for a package
  • Maybe have better support for packages that don't have wheels (add some hacky setup.py parsing):
    # TODO: consider allowing external dependencies for stubs for packages that do not ship wheels.
@Avasam
Copy link
Contributor

Avasam commented Jan 14, 2023

Maybe have better support for packages that don't have wheels (add some hacky setup.py parsing)

Could you look at *.egg-info/requires.txt ? It may not cover all cases. But the problematic ones right now (pycocotools and click-default-group) would work. Feels less hacky, simpler, and doesn't require executing code. Just need to download and unzip the package.

Also possibly useful feature requests:
pypi/warehouse#474
pypi/warehouse#8254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants