Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Major Release #2

Open
blakeembrey opened this issue Feb 5, 2016 · 4 comments
Open

Major Release #2

blakeembrey opened this issue Feb 5, 2016 · 4 comments

Comments

@blakeembrey
Copy link
Member

Goals:

Feel free to add things in, but I'll be trying to develop some features for the current iteration while this batch works well as a major release together because it's a pretty big refactoring (and some breaking changes in architecture).

@unional
Copy link
Member

unional commented Feb 5, 2016

@blakeembrey
Copy link
Member Author

I'm pretty sure module augmentation is covered with TS 1.8+, but I really need to double check ASAP - https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#augmenting-globalmodule-scope-from-modules.

@unional
Copy link
Member

unional commented Feb 5, 2016

Sure. But while it is covered, the generate code need to change so it will work correctly?
I guess supporting global would work, but augmenting others may not when they are nested?

I mean (using chai and chai-http) as example. The generated code:

declare module `chai-http/dist/main` {
  declare module `chai` {
    // augmentation
  }
  ...
}

declare module 'chai-http' {
  export * from 'chai-http/dist/main';
}

or for the hash version:

// typings/.store/hashABC.d.ts
declare module 'chai' {
  // augmentation
}
export ...

// typings/main/chai-http.d.ts
declare module 'chai-http' {
  export * from '../.store/hashABC.d.ts'
}

Would chai be augmented? 🌹

May be I am just not sure about what this mean:

... and are directly nested either your own modules, or in another top level ambient external module

@blakeembrey
Copy link
Member Author

An update - some of these features will likely come out in minors, while content hashing will be 1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants