-
Notifications
You must be signed in to change notification settings - Fork 81
Maintainership transfer of uBlock: post mortem
On April 1st, when I transferred maintainership of uBlock[1], as far as I am concerned, I was transferring to the The uBlock Development Team. In practice, of course I had to transfer to one of the member of the The uBlock Development Team, which happened to be @chrisaljoudi.
Things did not turn out as expected. A few days afterward, I learned that @chrisaljoudi had proceeded to immediately misrepresent (and still does as of April 24th) the project on his home page with "made [...] by Chris". uBlock is not made by @chrisaljoudi, it is made by The uBlock Development Team[2], of which @chrisaljoudi was one of the developer[3]. This misrepresentation is made worst by the fact that it was coupled with a plea for donations.[4]
I have nothing against developers asking for donations for writing free and open source software, this is very common and there is nothing wrong with this. It's a personal choice. However, I don't tolerate too well misrepresentation in order to financially benefit from the work of others, which I now conclude is the case here -- there is so much assumption of good faith one can give.
Before @chrisaljoudi took over the project, his github contribution stats were "2,397 ++ / 2,734 --" (meaning "2,397 lines removed, 2,734 lines added" -- and this covers more than just actual coding work). Currently, his github contribution stats on https://github.com/chrisaljoudi/uBlock stand at "22,057 ++ / 15,483 --".
You might be fooled into thinking there is a lot of work contributed since he took over in these stats, but the reality is that most of these "contributions" (17,827 ++ / 10,542 --) are the results of running the assets/update-3rdparties.sh
script, which purpose is to pull and commit changes in the 3rd-party filter lists (EasyList, EasyPrivacy, Peter Lowe's, etc.), so these are really other people contributions -- the maintainers of filter lists.[5]
I am perplexed as to why @chrisaljoudi as been currently updating the 3rd-party assets so often, there is no real need for doing so, as the cached filter lists will be updated by uBlock itself every 4-5 days on the user side, so it is rather pointless to update the repo -- and this even bad, as this causes uBlock to see the filter lists as obsolete and pull again what might just have been pulled an hour ago. The best time to run the assets/update-3rdparties.sh
script is when a package is created for a new release.
So anyways, removing the contributions from the automated script, this means @chrisaljoudi's git contributions become 1,833 ++ / 2,207-- since he took over maintainership. Now my point is not to understate the work done, rather to be sure it is not (conveniently) overstated -- given development work is used as an argument in seeking donations.[7]
Now factor in that many commits were actually to commit pull requests from other contributors, add to this that some of his changes were to actually remove code (per-site switches are gone), and add to this that @chrisaljoudi pulled development work from my branch with authorship stripped[6] (which would likely fool an outsider into thinking he worked to develop the code[7])
I have exhausted all assumption of good faith I could give, this is currently what I see about the chrisaljoudi/uBlock repo:
- uBlock is still the product of a whole lot of work by many different contributors
- Removing authorship information
- Misrepresentation: uBlock is "made [...] by Chris"
- To me it does appear most of the work by @chrisaljoudi since taking over has been to market uBlock.
- @chrisaljoudi actively seeking donations to "make uBlock happens"[8]
- On December 13th 2014, @chrisaljoudi wrote me, he was interested to "send over [...] < $1,000 to support the work on the Safari version"[9]
Bluntly said, my opinion from what I have observed, and in hindsight, I now believe @chrisaljoudi's primary motivation is to cash in on uBlock.
For insight, look at RequestPolicy Continued, which is the continuation of RequestPolicy. See the glaring differences in the spirit of the project.
Given all this, I will just keep developing uBlock Origin as if I was working on the original repo.
I will just ensure now that it doesn't turn into a customer support outlet for filter lists and endless requests for features (to keep throwing "features" at a piece of software is a good way to sabotage it -- so I am currently extremely selective).
uBlock is mature, most issues encountered nowadays are with the filter lists, and this could be taken care by volunteers elsewhere than on the github repo (I think there is a reddit section somewhere now).
[1] Because most of my own time had become invested in "customer support" rather than development work.
[2] More accurately, "All the uBlock contributors", which is something I corrected in my own branch.
[3] To work on, and improve the Safari port, which was originally brought to life by @Deathamns.
[4] Hence the reason I tried to reclaim uBlock's original name.
[5] @chrisaljoudi immediately toned down my original emphasis on the contributions of filter list maintainers upon taking over maintainership of uBlock.
[6] I undestand sometimes it may be desirable to import manually changes, in such case the solution is to document where the code comes from.
[7] https://chrismatic.io/ublock/: "your donations keep development possible"
[8] uBlock is already a reality and mature, it already "happened".
[9] I had completely forgotten about that email. I never answered to it because it annoyed me at the time and I just dismissed it immediately: the Safari port was already done by @Deathamns, and it bothered me that he was offering to pay me (which I clearly mention not wanting in the project), and worst, to pay me for the work of someone else (@Deathamns). I never answered back and dismissed the email as yet another annoying unsolicited uBlock-related email. I found this email I had forgotten when uBlock Origin was pulled from the Chrome store, I was trying to find the email notification supposedly sent by the Chrome store. In retospect, I now see very well the point of his offer: to cash in on a Safari version of uBlock.
- Wiki home
- About the Wiki documentation
- Permissions
- Privacy policy
- Info:
- The toolbar icon
- The popup user interface
- The context menu
-
Dashboard
- Settings pane
- Filter lists pane
- My filters pane
- My rules pane
- Trusted sites pane
- Keyboard shortcuts
- The logger
- Element picker
- Element zapper
-
Blocking mode
- Very easy mode
- Easy mode (default)
- Medium mode (optimal for advanced users)
- Hard mode
- Nightmare mode
- Strict blocking
- Few words about re-design of uBO's user interface
- Reference answers to various topics seen in the wild
- Overview of uBlock's network filtering engine
- uBlock's blocking and protection effectiveness:
- uBlock's resource usage and efficiency:
- Memory footprint: what happens inside uBlock after installation
- uBlock vs. ABP: efficiency compared
- Counterpoint: Who cares about efficiency, I have 8 GB RAM and|or a quad core CPU
- Debunking "uBlock Origin is less efficient than Adguard" claims
- Myth: uBlock consumes over 80MB
- Myth: uBlock is just slightly less resource intensive than Adblock Plus
- Myth: uBlock consumes several or several dozen GB of RAM
- Various videos showing side by side comparison of the load speed of complex sites
- Own memory usage: benchmarks over time
- Contributed memory usage: benchmarks over time
- Can uBO crash a browser?
- Tools, tests
- Deploying uBlock Origin
- Proposal for integration/unit testing
- uBlock Origin Core (Node.js):
- Troubleshooting:
- Good external guides:
- Scientific papers