Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing framework: exposed some flags for unhandled signals before completing workflows #1085

Open
longquanzheng opened this issue Apr 14, 2021 · 0 comments
Open

Testing framework: exposed some flags for unhandled signals before completing workflows #1085

longquanzheng opened this issue Apr 14, 2021 · 0 comments
Labels
enhancement test Related to testing up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@longquanzheng
Copy link
Collaborator

longquanzheng commented Apr 14, 2021 •
edited
Loading

cadence-client/internal/internal_workflow.go

Line 554 in 65903f7

env.GetMetricsScope().Counter(metrics.UnhandledSignalsCounter).Inc(1)

We may return some flag in the test env so that users can assert on it.
@longquanzheng longquanzheng changed the title Testing framework: return error on unhandled signals before completing workflows Testing framework: exposed some flags for unhandled signals before completing workflows Apr 14, 2021
@longquanzheng longquanzheng reopened this Apr 14, 2021
@ibarrajo ibarrajo added enhancement test Related to testing up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement test Related to testing up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibarrajo @longquanzheng