From e9bb11cf25e1dc52bbc3e6e2b0fea0446e503902 Mon Sep 17 00:00:00 2001 From: junya koyama Date: Wed, 27 Mar 2024 23:42:42 +0900 Subject: [PATCH 1/2] remove golangci-lint --version flags Signed-off-by: junya koyama --- .github/workflows/go.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 3ec8881f5..97a99db22 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -61,8 +61,7 @@ jobs: - uses: golangci/golangci-lint-action@v4 name: Install golangci-lint with: - version: latest - args: --version # make lint will run the linter + version: latest # make lint will run the linter - run: make lint name: Lint From 8a8ce0f556f018a89b1d20a9f38522e268e41395 Mon Sep 17 00:00:00 2001 From: Abhinav Gupta Date: Wed, 27 Mar 2024 08:52:38 -0700 Subject: [PATCH 2/2] add back install-only hack --- .github/workflows/go.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 97a99db22..790ebdf43 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -61,7 +61,10 @@ jobs: - uses: golangci/golangci-lint-action@v4 name: Install golangci-lint with: - version: latest # make lint will run the linter + version: latest + # Hack: Use the official action to download, but not run. + # make lint below will handle actually running the linter. + args: --help - run: make lint name: Lint