New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay should also check & compare if the decision results are the same #656

Open

longquanzheng opened this issue Nov 16, 2021 · 1 comment

Labels

bug

Collaborator

longquanzheng commented Nov 16, 2021

cadence-java-client/src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java

Line 219 in dca853a

byte[] queryResult = decider.query(decisionTask, decisionTask.getQuery());

cadence-java-client/src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java

Line 145 in dca853a

Decider.DecisionResult result = decider.decide(decisionTask);

Collaborator Author

longquanzheng commented Jan 13, 2022

^ this means that changing the timer value or activity input type will not break determinism check.

demirkayaender added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment