Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Update grpcurl dependency to fix breakage caused by protobuf v1.4.0 #559

Open
sfllaw opened this issue Jun 4, 2020 · 5 comments
Open

Update grpcurl dependency to fix breakage caused by protobuf v1.4.0 #559

sfllaw opened this issue Jun 4, 2020 · 5 comments
Assignees
Labels
1.11 Issue will be released with v1.11

Comments

@sfllaw
Copy link

sfllaw commented Jun 4, 2020

Problem

user@host:~/go/src/myprog$ go mod tidy
go: finding module for package github.com/golang/protobuf/jsonpb/jsonpb_test_proto
github.corp.qc/qc/bidding-rate-card-service/internal/gomod imports
        github.com/uber/prototool/cmd/prototool imports
        github.com/uber/prototool/internal/cmd imports
        github.com/uber/prototool/internal/exec imports
        github.com/uber/prototool/internal/grpc imports
        github.com/fullstorydev/grpcurl tested by
        github.com/fullstorydev/grpcurl.test imports
        github.com/golang/protobuf/jsonpb/jsonpb_test_proto: module github.com/golang/protobuf@latest found (v1.4.2), but does not contain package github.com/golang/protobuf/jsonpb/jsonpb_test_proto

This is caused because the v1.3.5 is the last version that contains github.com/golang/protobuf/jsonpb/jsonpb_test_proto. Protobuf v1.4 removed it, which was a backwards-incompatible change.

Solution

fullstorydev/grpcurl#145 fixes the bug, but this requires a change to Prototool’s go.mod to require at least v1.5.1:

github.com/fullstorydev/grpcurl v1.4.0

I'm not sure if there would be any harmful side-effects to bumping the version requirement. gRPCurl doesn’t force a newer version of protobuf, so things should be OK.

@sunwen18
Copy link

sunwen18 commented Jun 5, 2020

Noted, thanks for this, I'll update this.

@sunwen18 sunwen18 self-assigned this Jun 9, 2020
@sunwen18 sunwen18 added the 1.11 Issue will be released with v1.11 label Jun 9, 2020
@AlekSi
Copy link

AlekSi commented Jun 25, 2020

Would it be possible to do a small release with just that change?

@mdreizin
Copy link

@sunwen18 Do you have any updates?

@jnvillar
Copy link

I am needing this fix also

@chapmanc
Copy link

chapmanc commented Mar 3, 2021

Hi @sunwen18! I'd really like this if you could get some time to roll it :). Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.11 Issue will be released with v1.11
Projects
None yet
Development

No branches or pull requests

6 participants