-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve failure reporting #17
Conversation
* Consistently start property names with uppercase letters * Default topic is tactile_state*s*
... instead of receive time of message
Hi, The no message received yet is valid too, unless the clock resets. The tactile_plugin was used with default settings, so topic was /tactile_states, I will review the code next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine to me, and I could not reproduce the bug I noticed this morning with a bagfile with contact_state_plugin remembering previous data. Was probably a misconfiguration of the clock somehow during that early tests.
Indeed, |
10a2706
to
57fb1e9
Compare
Resolves #16.
I only partially handled your new request for a warning/error about an received, but outdated message.
It's implemented for TactileStateDisplay, but not for TactileContactDisplay. The latter would require this check for each and every contact received (within a message), which is somewhat costly.
You also note this issue "automatically", by not seeing wrenches displayed anymore, but no warning "no recent msg" popping up.
I tested this thoroughly with the enclosed `tactile_states` generator script: