Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User un-assign should close its linked pull-requests #74

Open
gentlementlegen opened this issue Nov 3, 2024 · 2 comments · May be fixed by #77
Open

User un-assign should close its linked pull-requests #74

gentlementlegen opened this issue Nov 3, 2024 · 2 comments · May be fixed by #77
Assignees
@gentlementlegen
Labels
Time: <1 Hour

Comments

@gentlementlegen
Copy link
Member 

          Disqualify needs to close the pull

Originally posted by @0x4007 in ubiquity-os-marketplace/daemon-merging#22 (comment)
@gentlementlegen gentlementlegen self-assigned this Nov 3, 2024
@ubiquity-os-beta ubiquity-os-beta
Copy link

A new workroom has been created for this task. Join chat

Open
@gentlementlegen gentlementlegen linked a pull request Nov 4, 2024 that will close this issue
Open
@gentlementlegen
Copy link
Member Author

gentlementlegen commented Nov 4, 2024 •
edited
Loading

@0x4007 The root of this problem was caused by 2 factors:

  • the value checked for the assigned person that got un-assigned was wrong
  • the event gets skipped because the sender is a bot (disqualifier plugin). We should add a skipBotEvents: false to our configuration.

Also you can set the priority of this task, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gentlementlegen gentlementlegen

Labels
Time: <1 Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure assignee is checked in userUnassigned handler gentlementlegen/command-start-stop
1 participant
@gentlementlegen