Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional NFT Types #88

Open
0x4007 opened this issue Oct 12, 2024 · 10 comments · May be fixed by #90 or #95
Open

Optional NFT Types #88

0x4007 opened this issue Oct 12, 2024 · 10 comments · May be fixed by #90 or #95
Assignees
@luisantoniocrag
Labels
Price: 6 USD Priority: 1 (Normal) Time: <15 Minutes

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 12, 2024 •
edited
Loading

We should fix the type checks in another pull and make these optional probably?

Originally posted by @0x4007 in #69 (comment)

Do it with TypeBox
Open
@rajiknows
Copy link

cant find that file

@0x4007
Copy link
Member Author

0x4007 commented Oct 14, 2024

@whilefoo rfc

@whilefoo
Copy link
Contributor

https://github.com/ubiquity-os/permit-generation/blob/development/src/types/env.ts

@luisantoniocrag
Copy link

/start

@ubiquity-os-beta ubiquity-os-beta
Copy link

@luisantoniocrag the deadline is at Sat, Oct 19, 8:03 AM UTC

@luisantoniocrag luisantoniocrag linked a pull request Oct 19, 2024 that will close this issue
Open
@luisantoniocrag
Copy link

If I understood correctly, it is to make those two variables optional and fix the check that causes that change, right?

@luisantoniocrag
Copy link

/wallet 0xbF5aBF239267DDF3e99aB1aEa20626f449368fBf

@ubiquity-os-beta ubiquity-os-beta
Copy link 

+ Successfully registered wallet address

@imabutahersiddik

This comment was marked as spam.

Sign in to view
@ubiquity-os-beta ubiquity-os-beta
Copy link 

! This issue is already assigned. Please choose another unassigned task.

@imabutahersiddik imabutahersiddik linked a pull request Oct 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luisantoniocrag luisantoniocrag

Labels
Price: 6 USD Priority: 1 (Normal) Time: <15 Minutes
Projects
None yet
Milestone
No milestone
5 participants
@0x4007 @luisantoniocrag @rajiknows @imabutahersiddik @whilefoo