Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permit2 approval #29

Open
rndquu opened this issue Nov 18, 2024 · 14 comments · May be fixed by #30
Open

Add permit2 approval #29

rndquu opened this issue Nov 18, 2024 · 14 comments · May be fixed by #30

Comments

@rndquu
Copy link
Member

rndquu commented Nov 18, 2024

Right now this repository is a 2-step setup wizard:

  • Step 1: create ubiquity-os config
  • Step 2: approve permit2 contract to spend tokens

Since the ubiquity-os config is now created in https://github.com/ubiquity-os/ubiquity-os-plugin-installer we should refactor the code in this repository:

  1. Remove Step 1: create "ubiquity-os" config
  2. Allow partner to approve permit2 contract to spend funds on partner's behalf
  3. Rename current repository to smth like permit2-allowance.ubq.fi and deploy the frontend
  4. Add permit2-allowance.ubq.fi URL to the readme file of https://github.com/ubiquity-os-marketplace/text-conversation-rewards
@zugdev
Copy link

zugdev commented Nov 18, 2024

Can I refactor it entirely?

@rndquu
Copy link
Member Author

rndquu commented Nov 18, 2024

Can I refactor it entirely?

Yes

@zugdev
Copy link

zugdev commented Nov 18, 2024

/start

Copy link

ubiquity-os bot commented Nov 18, 2024

Deadline Mon, Nov 18, 6:14 PM UTC
Beneficiary 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@zugdev
Copy link

zugdev commented Nov 18, 2024

This, post refactor, might fit best in pay.ubq.fi when you connect with a treasury address.

@0x4007
Copy link
Member

0x4007 commented Nov 18, 2024

I think we should leave everything in separate codebases as much as possible to make maintenance simpler.

Copy link

ubiquity-os bot commented Nov 20, 2024

Passed the deadline and no activity is detected, removing assignees: @zugdev.

Copy link

ubiquity-os bot commented Nov 20, 2024

@zugdev the deadline is at Wed, Nov 20, 9:32 AM UTC

@zugdev
Copy link

zugdev commented Nov 21, 2024

Is there an easy way to get the current reward token for an org?

@zugdev zugdev linked a pull request Nov 21, 2024 that will close this issue
@rndquu
Copy link
Member Author

rndquu commented Nov 21, 2024

Is there an easy way to get the current reward token for an org?

https://github.com/ubiquity-os/.ubiquity-os/blob/63bd7e7747c92262caf0a41cadf4f5bb1acc1884/.github/.ubiquity-os.config.dev.yml#L46

If erc20RewardToken param is no set then default values are DAI for mainnet and WXDAI for gnosis.

Copy link

ubiquity-os bot commented Nov 24, 2024

Passed the deadline and no activity is detected, removing assignees: @zugdev.

@zugdev zugdev self-assigned this Nov 26, 2024
Copy link

ubiquity-os bot commented Dec 1, 2024

Passed the deadline and no activity is detected, removing assignees: @zugdev.

Copy link

ubiquity-os bot commented Dec 19, 2024

@zugdev the deadline is at Fri, Dec 20, 8:54 AM UTC

Copy link

ubiquity-os bot commented Dec 19, 2024

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 2 days and 8 hours if there is no activity.
  • Assignees will be disqualified after 4 days and 16 hours of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants