-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an approval/funding UI #30
base: development
Are you sure you want to change the base?
Conversation
Unused dependencies (4)
Unused devDependencies (2)
|
There should be a separate input for a token. When mainnet or gnosis is selected the UUSD should be set in the input token field by default but user should have the ability to change the token address.
Check this comment. Overall github auth is not necessary as a part of the current github issue and can be solved in another PR. |
@zugdev, this task has been idle for a while. Please provide an update. |
I wonder if it makes sense for us to bridge over to as many chains as we can. I suppose anybody can do this and we just need to aggregate the addresses.
This is actually determined by the partner project currently. So in theory we could have partner A, B, and C and each pays with their own preferred token on their own preferred chain. This is because they need to fund their wallets with whatever asset they want.
|
I think aside from providers that's it. I need to find a smart way to use providers in all 10+ chains, why don't we use Alchemy or some service like that? |
Interesting. Makes it accessible to all devices in the network. I can run it on my PC and phone without any extra config. Cool |
Regarding the dark/light theme, this was not in scope for this task, so sticking to only the dark one is also fine. |
Regarding the changes:
Since e2e tests and responsive CSS were not in the initial task scope it makes sense to increase the estimated time to @zugdev Overall looks good. Pls fix the above comments. |
I also get the same error as rndquu and EresDev
It seems that it's trying to send a transaction using eth_sendTransaction which accepts an unassigned tx and assumes that the RPC node will sign the transaction, we should just use user's wallet to send the transaction instead |
…into development
thanks for the input guys, very valid. I kinda disagree with needing an e2e test set, cause it's just a mere approve() transaction, can we reconsider it? transactions weren't going through cause reown isn't properly injecting pk into signer, I have changed to capture injected wallet (standard window.ethereum stuff) |
@zugdev, this task has been idle for a while. Please provide an update. |
Resolves #29
I like the word funding better than approval, allowance or permit2, as it is better aligned with the "ubiquity banking" concept. Don't worry bout the text, it still needs rephrasing.
Current UI:
I have a couple questions:
Should I force UUSD or should I offer an input field for token. If I should force, what about chains where UUSD is not at currently? I've included all permit2 chains I could, for now.
I don't want to have user authenticate with GitHub, it's an unnecessary step, but if I did I could read what chain he has payments setup in. Is there a way to read what token he is using as reward too? If that was the case I should consider adding GitHub auth.
I am waiting on the above to integrate ethers.