-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save EOA to a DB #3
Comments
@Keyrxng Pls check the description and put a time estimate |
In order to decentralize but share data storage, perhaps we can have users set up their own For it to be private, the users must install the bot to their account. The user can also host some plugin there, which opens up the "personal agent" proposal as a possibility. Otherwise they can register wallets to each organization, which also might not really be a problem in the medium term. |
Overall it adds an extra burden for a contributor to generate a repo, install the bot, etc... We already "ask" partners to generate |
I'd keep the We could have each partner add the bot or another account and we use it's token or give us an access_token which we can use to read/write from our UI? access_token doesn't sound too attractive and and if we use the bot's I think that could be dangerous as it'll have access to all partners private configs. Perhaps it would be a better idea to create a core plugin that we can dispatch events to from the UI passing the user details and the org they are registering for. Then (afaik) the kernel could read/write their org config no problem. It may have to be a service binding to the kernel as opposed to a plugin but this could work right? |
Can pass installation ID in the query parameter and auth with GitHub to associate the correct org securely. |
If I understand correctly, the problem with this is the Github app used for logging into the various portals is a different Github app then what's installed in each org Unless we are storing these install IDs in our Supabase Or have a way to create the various tokens we need from the bot app to verify the install ID which might look like env vars? |
To generate the auth token we need the app ID, installation ID and app private key. With those three we can auth to any org with the matching installation ID. |
/wallet 0x8b46200A13a7018125a4682462aa2d86Fa93ae6c |
+ Successfully registered wallet address |
Depends on #2
Right now
safe.ubq.fi
is able to generate EOA address from a passkey but doesn't save it to a database.This way user has to perform an additional registration step:
/register
and the bot replies with "Pls create an EOA at safe.ubq.fi"safe.ubq.fi
/wallet
to register his address in our DB (additional step)We should support the following flow:
/register
and the bot replies with "Pls create an EOA at safe.ubq.fi"safe.ubq.fi
andsafe.ubq.fi
's backend saves user's address to a DBIdeally for a DB we should use a partner's json storage (i.e. his
ubiquibot-config
repository) but if ubiquity-os/plugin-template#2 is not implemented at the time somebody starts this issue then we can simply use our supabase instance and leave "json storage" for the next feature iteration.Original comment.
The text was updated successfully, but these errors were encountered: