-
Notifications
You must be signed in to change notification settings - Fork 61
Use Github IDs instead of names in DB #574
Comments
I agree that ID makes more sense for this reason. For convenience we should still also keep at least the original username. |
/start |
Skipping |
@pavlovcik Hey, I wanted to pick this up! |
/start |
Skipping |
@Sadaf-A The time limit for this bounty is on Mon, 07 Aug 2023 00:53:52 GMT |
@whilefoo could you please elaborate a little and if possible, link the GitHub file also. |
@pavlovcik I'm not sure how we can keep backwards compatibility. For issues and users it doesn't matter that much because we just insert them into DB and never query them, but we query other tables so things won't work because old records won't have IDs. I guess one way would be to first add IDs to the database and fill new records with both name and ID but still query by name. Then we create a script that will update all missing IDs and once we have everything we switch to querying by ID. |
Yeah I think we could even delete the old users to force re-registration. No big deal. |
/unassign |
You have been unassigned from the bounty @Sadaf-A |
@pavlovcik , here it is required to a "id" along with other details, right? Any additional changes? Thank You |
Available commands
|
I think all the relevant context is inside of this conversation but @whilefoo any remarks? |
My remarks |
These linked pull requests are closed: #618 |
/start |
Too many assigned issues, you have reached your max of 2 |
Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment |
Still waiting for review. |
Want to move to another issue because it's been a while for waiting for review... |
/stop |
These linked pull requests are closed: #656 |
You have been unassigned from the bounty @ByteBallet |
@ByteBallet The time limit for this bounty is on Tue, 05 Sep 2023 11:49:07 UTC |
Assigned you back :) Next time (when you hit the assignment limit) you don't need to unassign yourself from some old issue in order to take a new bounty. Just post a comment (under the issue you want to take) that you want to take a new issue but all your other PRs are under review and somebody from the core team will assign you. |
Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment |
@ByteBallet - Releasing the bounty back to dev pool because the allocated duration already ended! |
@ByteBallet The time limit for this bounty is on Tue, 12 Sep 2023 10:58:03 UTC |
@ByteBallet - Releasing the bounty back to dev pool because the allocated duration already ended! |
1 similar comment
@ByteBallet - Releasing the bounty back to dev pool because the allocated duration already ended! |
@pavlovcik The time limit for this bounty is on Thu, 19 Oct 2023 06:45:20 UTC |
@pavlovcik - Releasing the bounty back to dev pool because the allocated duration already ended! |
@pavlovcik The time limit for this bounty is on Thu, 19 Oct 2023 06:45:42 UTC |
+ Evaluating results. Please wait... |
@pavlovcik the deadline is at 2024-02-17T12:34:56.988Z |
+ Evaluating results. Please wait... |
Currently user, repository, organization are all stored by their name in the database. User, repo or organization can change their name and I guess this is not that common but I still think it would be better to store IDs that we get from the Github API instead of names.
The text was updated successfully, but these errors were encountered: