Fix DCONF policy manager removing userdb on empty policy #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
+ Coverage 93.80% 93.84% +0.03%
==========================================
Files 79 79
Lines 6881 6873 -8
==========================================
- Hits 6455 6450 -5
+ Misses 416 413 -3
Partials 10 10 ☔ View full report in Codecov by Sentry. |
2 tasks
didrocks
requested changes
Aug 28, 2024
didrocks
requested changes
Aug 28, 2024
This reverts commit bed0d79, reversing changes made to 0163cbb. Co-authored-by: Didier Roche-Tolomelli <[email protected]>
The reverted commit was before we added support for multiple backends, so we need to update the golden files for these tests.
denisonbarbosa
force-pushed
the
fix-dconf-empty-profile
branch
from
8bd2829
to
8a473d6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to go for this approach to support the
purgecommand. Since it's not yet fully functional and this change is breaking user sessions that do not have at least one DCONF-related policy applied, we should revert this change for now and consider a better way of removing the leftover files in the future.Closes #1002.
UDENG-3732.