Update packaging to support certificates policy #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- d/copyright: mention vendored samba files - d/control: add cepces to Suggests - d/dirs: mark /var/lib/adsys - d/rules: ship vendored python code Fixes UDENG-1157
This handles cases where the test runner already has a PYTHONPATH set, thus failing because of differences in the golden file output. Ideally we would pass the PYTHONPATH via a functional option in the manager constructor so we can maintain parallelism in tests, but I feel this approach is a decent compromise and we don't lose much in the process.
We are using errors.Join which is not available in older Go versions.
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 77 77
Lines 8552 8552
=======================================
Hits 7361 7361
Misses 868 868
Partials 323 323 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
denisonbarbosa
approved these changes
Aug 10, 2023
|
Looks good to me too. I agree with @denisonbarbosa though: can we get the changelog in a separate PR? |
didrocks
approved these changes
Aug 10, 2023
|
Good point, thanks for the suggestion! |
GabrielNagy
force-pushed
the
certificate-packaging-updates
branch
from
79c9f86
to
2fc3225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit for details.
Fixes UDENG-1157
Passing PPA build: https://launchpad.net/~gabuscus/+archive/ubuntu/ppa/+sourcepub/15065373/+listing-archive-extra
Local autopkgtests passing as well for amd64