Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#91 document > item renaming #103

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

garuna-m6
Copy link
Contributor

documentation changes generalizing document -> items

@garuna-m6
Copy link
Contributor Author

I believe at several places the word document makes more sense, please do mention the files that should be altered as well

@shreyashankar
Copy link
Collaborator

Thanks for this! I don't think there needs to be a code change anywhere; I was imagining just a small rename from document to item when mentioning datasets in the documentation.

The other documentation changes you made look good.

@garuna-m6
Copy link
Contributor Author

@shreyashankar re-review please, also can you recommend good beginner issue 👀

@shreyashankar shreyashankar self-requested a review October 14, 2024 14:18
@shreyashankar
Copy link
Collaborator

Thank you! #94 might be a good one to tackle (and has high impact); specifically the part where we want to trace the lineage of source documents. Instead of creating and using a sqlite db, maybe if the user specifies a path in their config for logging traces, we could log traces for each source document? We might have to require an id key for each source document if the user wants to log traces.

@shreyashankar
Copy link
Collaborator

Tests are failing bc of lack of access to openai key; they pass on my computer

@shreyashankar shreyashankar merged commit 0c6a4dd into ucbepic:main Oct 14, 2024
1 of 4 checks passed
@garuna-m6
Copy link
Contributor Author

Thank you! #94 might be a good one to tackle (and has high impact); specifically the part where we want to trace the lineage of source documents. Instead of creating and using a sqlite db, maybe if the user specifies a path in their config for logging traces, we could log traces for each source document? We might have to require an id key for each source document if the user wants to log traces.

will take some sweet time on this one, need to understand code to expectation context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants