-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#91 document > item renaming #103
#91 document > item renaming #103
Conversation
I believe at several places the word document makes more sense, please do mention the files that should be altered as well |
Thanks for this! I don't think there needs to be a code change anywhere; I was imagining just a small rename from
The other documentation changes you made look good. |
@shreyashankar re-review please, also can you recommend good beginner issue 👀 |
Thank you! #94 might be a good one to tackle (and has high impact); specifically the part where we want to trace the lineage of source documents. Instead of creating and using a sqlite db, maybe if the user specifies a path in their config for logging traces, we could log traces for each source document? We might have to require an id key for each source document if the user wants to log traces. |
Tests are failing bc of lack of access to openai key; they pass on my computer |
will take some sweet time on this one, need to understand code to expectation context |
documentation changes generalizing document -> items