Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure inactive accounts are not listed where they shouldn't be used. #398

Open
sprucely opened this issue Feb 20, 2024 · 2 comments
Open

Comments

@sprucely
Copy link
Contributor

For team foundation-plant-services there was a mixup between a couple accounts, one of which is inactive. We should probably go through all the queries hitting FinancialAccounts to make sure we're filtering out inactive ones when appropriate.

@jSylvestre
Copy link
Member

@sprucely There is code that catches when in inactive account is used. Was that when happened?

        try
        {
            invoices = await _invoiceService.CreateInvoices(model, team);
        }
        catch (ArgumentException ex)
        {
            ModelState.AddModelError(ex.ParamName, ex.Message);
            return new BadRequestObjectResult(new
            {
                success = false,
                errorMessage = "Errors found in request",
                modelState = ModelState
            });
        }

@sprucely
Copy link
Contributor Author

sprucely commented Mar 5, 2024

I would have to go through the tickets I closed that day, because I have no idea. From the title, I'd assume there is some dropdown or something that allowed a user to select an inactive account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants