Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added question bank value safeguarding #79

Merged

Conversation

dmols
Copy link
Contributor

@dmols dmols commented Aug 26, 2024

Essentially added a check on both save and word pair deletion, to update the question bank value if it's higher than that of the question count. This way, the player won't encounter a weird error using invalid question bank data.

Fixes #78 .

@dmols dmols added the bug Something isn't working label Aug 26, 2024
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clpetersonucf clpetersonucf changed the base branch from master to dev/1.2.1 September 17, 2024 19:20
@clpetersonucf clpetersonucf merged commit 4897258 into ucfopen:dev/1.2.1 Sep 17, 2024
1 check passed
@clpetersonucf clpetersonucf mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix question bank validation bug
2 participants