Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Buf::skip and Buf::tail redundant? #11

Open
Be-ing opened this issue Dec 2, 2022 · 2 comments
Open

Are Buf::skip and Buf::tail redundant? #11

Be-ing opened this issue Dec 2, 2022 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Dec 2, 2022

From reading the examples in the documentation, they seem to do the same thing. Also the text of the documentation for these functions is identical "Construct a new buffer where n frames are skipped."

@Be-ing
Copy link
Contributor Author

Be-ing commented Dec 2, 2022

Oh, does skip start n frames from the beginning of the buffer and tail start n frames back from the end? If so, the examples both go 2 frames into a 4 frame buffer, which happens to be the same result whether you go 2 from the beginning or 2 from the end. :) In that case, the examples could be adjusted to not index exactly half way into an even sized buffer.

@udoprog
Copy link
Owner

udoprog commented Dec 2, 2022

Yeah, I think it's just the documentation that is wrong.

@udoprog udoprog added bug Something isn't working documentation Improvements or additions to documentation labels Dec 2, 2022
Be-ing added a commit to Be-ing/audio that referenced this issue Dec 4, 2022
Be-ing added a commit to Be-ing/audio that referenced this issue Dec 10, 2022
Be-ing added a commit to Be-ing/audio that referenced this issue Dec 10, 2022
Be-ing added a commit to Be-ing/audio that referenced this issue Dec 10, 2022
Be-ing added a commit to Be-ing/audio that referenced this issue Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants