Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Microsoft Pinyin Input Method Fails to Complete Input After Enabling the CharacterCount Plugin #5878

Open
YanChenBai opened this issue Nov 27, 2024 · 1 comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Info: Help Wanted The issue or pullrequest needs help from the community Type: Bug The issue or pullrequest is related to a bug

Comments

@YanChenBai
Copy link

YanChenBai commented Nov 27, 2024

Affected Packages

@tiptap/extension-character-count

Version(s)

2.9.1

Bug Description

After using the CharacterCount plugin, the Microsoft Pinyin input method fails to complete input. The behavior is as follows when typing pinyin.

Browser Used

Edge

Code Example URL

https://stackblitz.com/~/github.com/YanChenBai/character-count-demo

Expected Behavior

Be able to complete pinyin input.

Additional Context (Optional)

2024-11-27.17-21-39.mp4
@YanChenBai YanChenBai added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Nov 27, 2024
@nperez0111
Copy link
Contributor

Hi @YanChenBai, I think that what we need to do here is to disable the limiter when composing.

I think that all that is needed here is && !this.editor.view.composing on this line:

if (!transaction.docChanged || limit === 0 || limit === null || limit === undefined) {

And probably to skip it for the append transaction too. Would accept a contribution here

@nperez0111 nperez0111 added the Info: Help Wanted The issue or pullrequest needs help from the community label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Info: Help Wanted The issue or pullrequest needs help from the community Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants