Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRO]: Deleting the first comment in a thread removes entire thread from provider #5932

Closed
1 task done
barretodaniel opened this issue Dec 13, 2024 · 1 comment
Closed
1 task done

[PRO]: Deleting the first comment in a thread removes entire thread from provider #5932

barretodaniel opened this issue Dec 13, 2024 · 1 comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@barretodaniel
Copy link

Affected Packages

extension-comments

Version(s)

2.16.3

Description of the Bug

Deleting the first comment in a thread deletes the thread from the provider even when there are still comments in the thread.

Browser Used

Chrome

Code Example (Preferred)

No response

Expected Behavior

Deleting the first comment in a thread when other comments are present should simply remove the comment from the thread data.

Additional Context (Optional)

Screen.Recording.2024-12-12.at.8.21.27.PM.mov

Dependency Updates

  • Yes, I've updated all my dependencies.
@barretodaniel barretodaniel added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Dec 13, 2024
@barretodaniel barretodaniel changed the title [PRO]: Deleting the first comment in a thread breaks extension [PRO]: Deleting the first comment in a thread removes entire thread from provider Dec 13, 2024
@barretodaniel
Copy link
Author

Closing since upgrading to the latest @hocuspocus/provider package changes the behavior to the expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barretodaniel