Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discourse extension has a wrong dependency #3

Open
choroba opened this issue Oct 10, 2024 · 5 comments
Open

discourse extension has a wrong dependency #3

choroba opened this issue Oct 10, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@choroba
Copy link
Collaborator

choroba commented Oct 10, 2024

At https://ufal.mff.cuni.cz/tred/extensions, discourse depends on nondeprel_common, but it's location is incorrectly referred to as external (should be core).

In the repository, the path is correct, but the version is 1.149, while the one ufal is 1.157. Where is it coming from and could it be fixed there (and probably removed from here)?

@choroba choroba added the bug Something isn't working label Oct 10, 2024
@jmirovsky
Copy link
Collaborator

jmirovsky commented Oct 10, 2024 via email

@jmirovsky
Copy link
Collaborator

jmirovsky commented Oct 10, 2024 via email

@matyaskopp
Copy link
Member

If you want to remove it, then I suggest preserving the folder in the same way as it is done in the pmltq extension https://github.com/ufal/TrEd-extensions/tree/main/pmltq
I am using an empty .gitkeep file there.

@jmirovsky
Copy link
Collaborator

jmirovsky commented Oct 10, 2024 via email

@choroba
Copy link
Collaborator Author

choroba commented Oct 10, 2024

Which brings me into an idea I've had recently. What about extending the package.xml with a new field which would say what repository the external extension comes from? So for example the new umr extension will have

<vc href="github.com:ufal/UMR/tred_extension/umr" path="tred_extension/umr" />

or something similar.

The problem is we need to extend the schema for the package.xml, which means old TrEd will not work with the new xml's. So we need at least a way to release a new TrEd 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants