Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manifest.json _version entry dependent on UI5 version #7

Open
petermuessig opened this issue Sep 2, 2023 · 1 comment
Open

Comments

@petermuessig
Copy link
Member

https://github.com/SAP/ui5-manifest/blob/master/mapping.json

@wridgeu
Copy link

wridgeu commented Jan 10, 2025

This seems like the appropriate place to ask if, or in what capacity, manifest changes are going to be reflected in the templates. For now I assume that a complete dynamic creation of the manifest.json, based on its version, is not planned.

Concrete Case
Some colleagues of mine stumbled over this recently. They created a UI5 project with the latest (1.131.1) UI5 version served via the CDN for some local testing. When navigation came into place they stumbled over the following error:

Image

Which was resolved when adjusting the viewPath property to the more current path property, see JSON schema.

Template file in question (reflecting "_version": "1.12.0"):

"config": {
"routerClass": "sap.m.routing.Router",
"viewType": "XML",
"viewPath": "<%= appId %>.view",
"controlId": "app",
"controlAggregation": "pages",
"async": true
},
- I'm not sure if this or something similar was also the intention behind this issue @petermuessig? :)

Note: I do understand that this might most likely be only an issue in the more recent UI5 versions, where this is is actually a "breaking" change/difference in the manifest config.


To be fair, I actually was not aware of this change or even the existence of legacyTargetAddition myself. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants