Fix pagination in combination with filters #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both pagination and filters use query parameters to provide variables to backend. They both individually work ok but the parameters gets overwritten if used in combination. Eg apply some filters and select a particular page from the list of results. In this case once a page is selected then existing query parameters gets overwritten with the selected page and because of this filters also gets cleared. The fix is to append the variables instead of overwriting them which is implemented using custom template tags.
currycoder
reviewed
Apr 27, 2020
| @@ -91,3 +91,31 @@ def query_params_has_value(value, param_key, query_params): | |||
| @register.simple_tag | |||
| def query_params_value_selected(value, param_key, query_params, text='selected'): | |||
| return f' {text}' if str(value) in query_params.getlist(param_key) else '' | |||
|
|
|||
|
|
|||
| @register.simple_tag | |||
There was a problem hiding this comment.
I think these tag functions need some tests.
|
Closing this PR as another PR has been merged to fix this issue in another way (#103). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Both pagination and filters use query parameters to provide variables
to backend. They both individually work ok but the parameters gets
overwritten if used in combination. Eg apply some filters and select
a particular page from the list of results. In this case once a page
is selected then existing query parameters gets overwritten with the
selected page and because of this filters also gets cleared.
The fix is to append the variables instead of overwriting them which
is implemented using custom template tags.
This PR fixes #46