Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoints wont work with minio #14

Open
remche opened this issue Apr 26, 2020 · 1 comment
Open

Checkpoints wont work with minio #14

remche opened this issue Apr 26, 2020 · 1 comment

Comments

@remche
Copy link

remche commented Apr 26, 2020

Because of minio relying on POSIX namespace for file backend (minio/minio#1291), saving checkpoint fails with Object-prefix is already an object, please choose a different object-prefix name..

Choosing a different prefix for checkpoints will fix it.

@michalc
Copy link
Member

michalc commented Apr 26, 2020

Hi @remche,

Thanks for the report. This is a tricky one... while working with S3 is an aim of project, I'm torn about making changes for it to work with things that are not S3, or not fully S3-compatible, like minio.

I'll have more of a think, but in the meantime, right now you can probably monkey-patch the _checkpoint_path and _list_checkpoints functions in https://github.com/uktrade/jupyters3/blob/master/jupyters3/jupyters3.py to be more minio-compatible: _checkpoint_path converts the path of a notebook and a checkpoint ID to a path of a checkpoint file, and _list_checkpoints takes a path of a notebook and should return a list of {'id': ..., 'last_modified': ...} of checkpoints for that notebook.

Thanks,

Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants