Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yasmin_viewer missing dependencies #33

Open
reinzor opened this issue Oct 24, 2024 · 4 comments
Open

yasmin_viewer missing dependencies #33

reinzor opened this issue Oct 24, 2024 · 4 comments

Comments

@reinzor
Copy link
Contributor

reinzor commented Oct 24, 2024

[yasmin_viewer_node-48]   File "/install/yasmin_viewer/lib/yasmin_viewer/yasmin_viewer_node", line 35, in <module>
[yasmin_viewer_node-48]     from waitress import serve
[yasmin_viewer_node-48] ModuleNotFoundError: No module named 'waitress'

The waitress dependency is not listed in the package.xml

It can be resolved using rosdep: https://github.com/ros/rosdistro/blob/faf08fa8c6a18790b52e984ab9a2d643911a785d/rosdep/python.yaml#L10283

@reinzor
Copy link
Contributor Author

reinzor commented Oct 24, 2024

Same holds for expiringdict:

Traceback (most recent call last):
  File "/install/yasmin_viewer/lib/yasmin_viewer/yasmin_viewer_node", line 36, in <module>
    from expiringdict import ExpiringDict
ModuleNotFoundError: No module named 'expiringdict'

But there does not seem to be a rosdep rule for that one.

@reinzor
Copy link
Contributor Author

reinzor commented Oct 24, 2024

Same holds for expiringdict

Added that one here ros/rosdistro#43261

@reinzor
Copy link
Contributor Author

reinzor commented Oct 24, 2024

@mgonzs13
Copy link
Collaborator

Nice work @reinzor . I really like depending only on rosdep for the dependencies. I'll have to check more on the available python packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants