Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safeDecodeURIComponent is breaking non-ASCII charactes from cloudflare headers #3093

Open
delemeator opened this issue Dec 8, 2024 · 0 comments

Comments

@delemeator
Copy link

delemeator commented Dec 8, 2024

Describe the Bug

When using cloudflare headers cf-ipcountry, cf-region-code and cf-ipcity, non-ASCII characters are converted by Cloudflare to UTF-8 using hexadecimal character representation. (https://developers.cloudflare.com/rules/transform/managed-transforms/reference/#encoding-of-non-ascii-header-values)

This leads to following problems with safeDecodeURIComponent function that is used by Umami to decode them:

image

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

No response

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant