Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekday directive looses "connection" to parent scope #33

Open
enkelmedia opened this issue Oct 18, 2018 · 1 comment
Open

Weekday directive looses "connection" to parent scope #33

enkelmedia opened this issue Oct 18, 2018 · 1 comment

Comments

@enkelmedia
Copy link

enkelmedia commented Oct 18, 2018

I've played around with this great property editor but after making some changes i the dropdowns for opening hours the parent model does not get updated anymore.

I've added some debugging to the views and the model inside the holiday-directive gets updated correctly and the first couple of times I update the drop downs the parent mode (model.value.holidays) is also updates. But after some time (it's random) the parent models does not get updated any more.

I've tried to figure out what the problem is but I can't really figure it out at the moment. Anybody else that have seen this issue?

parent direcitve

@enkelmedia
Copy link
Author

I think I've figured out the issue.

When we save and publish, the model from the server is passed back again and the "parent" model is updated. When this happens, the "connection" between them breaks. I need to look closer at this and see if there is something we can do about that.

enkelmedia pushed a commit to enkelmedia/Our.Umbraco.OpeningHours that referenced this issue Oct 18, 2018
enkelmedia pushed a commit to Obviuse/Our.Umbraco.OpeningHours that referenced this issue Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant