Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/filtering-changes #47

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

grimurd
Copy link

@grimurd grimurd commented Apr 26, 2019

Making a few changes to filtering

  • Make filtering case insensitive.
  • When tab is pressed with invalid input treat it as text search
  • Always select top result when tab is pressed

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2ac4048). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   20.18%           
=========================================
  Files             ?        1           
  Lines             ?      327           
  Branches          ?       67           
=========================================
  Hits              ?       66           
  Misses            ?      254           
  Partials          ?        7
Impacted Files Coverage Δ
...les/ngx-magic-search/ngx-magic-search.component.ts 20.18% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac4048...c1ed3c8. Read the comment docs.

@grimurd grimurd changed the base branch from master to develop April 27, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant