Rename org short code feature added #550
Conversation
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (07/09/24)1 assignee was added to this PR based on Rahul Mishra's automation. |
There was a problem hiding this comment.
I checked the code, everything looks ok
but i realized we will have some big issues if we enable this
the orgshortcode is passed to all api queries
and used to lookup org info from a redis cache
if we allow orgs to change shortcode, the old shortcode will still work for a while (till cache expires)
this isnt a problem
the problem is other users might still be using the old shortcode in the url
so they wouldnt know that the orgshortcode has changed
once the cache expires, the next api call they make will fail
need to work out the best way to redirect logged in org members to the new URL, without the risk of them writing a long email, pressing send, and the api call failing...
@BlankParticle thoughts?
|
there are lot of stuff tied to org short code, if we want to change org short code we need a list of burnt orgshort codes and make older codes redirect to new codes. Invalidating cache is not a big issue tho That also means every query would need to check if org shortcode has been redirected before proceding I think we should delay this feature until we have a good flow planned |
|
I checked some cases, if the user uses the URL with the old code it redirects to: And yeah, the old code still works for the active user it's not updating automatically the inbox and conversations are opening fine. |
|
Also, the |
|
@BlankParticle I dont think we need to burn shortcodes the same way we burn usernames we already have a method to invalidate an org's shortcode cache |
|
@yash-kh 99% of queries use the |
|
I think we should put this in backlog for now |
BlankParticle
added
the
backlog
What does this PR do?
Rename org short code Option added in:
settings -> Organization -> Org profile
Fixes #307
Type of change