Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-Only Modal - FF/Safari #10

Open
sturobson opened this issue Oct 11, 2016 · 4 comments
Open

CSS-Only Modal - FF/Safari #10

sturobson opened this issue Oct 11, 2016 · 4 comments

Comments

@sturobson
Copy link

first up... Love this!

(back story: I consume links clicked in twitter / reeder in Safari)

Opening up the site, I clicked through and noticed this one doesn't want to work. I opened the CodePen fully - http://codepen.io/una/full/pEVjwj/ - and tried it in Safari 9.1 (so this might be fixed in Sierra) and FireFox (dev. edition) 51.0a2

I'll try and dig into why, what needs fixing, but can't guarantee when :(

Lovely project :)

@shadeed
Copy link
Contributor

shadeed commented Oct 11, 2016

This is a very interesting issue! What I have noticed so far:

  • It works in FF if the focus came from keyboard.
  • Works in Safari if we forced :focus from dev tools.
  • keyboard :focus is not working in Safari. I even added a link and can't move focus to it.

Also, for some reason the modal is not centered in Safari. This is a screenshot when forcing :focus

screen shot 2016-10-11 at 10 30 43 pm

Update

It works in FF now. The only issue is still in Safari, still not accepting focus from mouse or keyboard. Here is the pen:
http://codepen.io/shadeed/pen/bwrjKX/

@jpdevries
Copy link

This is really clever!

@shadeed focus from keyboard in Safari should work if you have tab to highlight enabled

still doesn't work with clicking in Safari though.

@shadeed
Copy link
Contributor

shadeed commented Oct 12, 2016

@jpdevries Thank you! I learned something new. :)

Now it's working from keyboard and yes clicking still doesn't working.

@marcysutton
Copy link
Contributor

this should be fixed with #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants