-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-Only Modal - FF/Safari #10
Comments
This is a very interesting issue! What I have noticed so far:
Also, for some reason the modal is not centered in Safari. This is a screenshot when forcing :focus Update It works in FF now. The only issue is still in Safari, still not accepting focus from mouse or keyboard. Here is the pen: |
This is really clever! @shadeed focus from keyboard in Safari should work if you have tab to highlight enabled still doesn't work with clicking in Safari though. |
@jpdevries Thank you! I learned something new. :) Now it's working from keyboard and yes clicking still doesn't working. |
this should be fixed with #46 |
first up... Love this!
(back story: I consume links clicked in twitter / reeder in Safari)
Opening up the site, I clicked through and noticed this one doesn't want to work. I opened the CodePen fully - http://codepen.io/una/full/pEVjwj/ - and tried it in Safari 9.1 (so this might be fixed in Sierra) and FireFox (dev. edition) 51.0a2
I'll try and dig into why, what needs fixing, but can't guarantee when :(
Lovely project :)
The text was updated successfully, but these errors were encountered: