Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring event dates #58

Open
Legin76 opened this issue Aug 12, 2014 · 5 comments
Open

Recurring event dates #58

Legin76 opened this issue Aug 12, 2014 · 5 comments

Comments

@Legin76
Copy link

Legin76 commented Aug 12, 2014

I'm trying to set up a re-occurring event for each weekend.

I've set up the event to show up every week on Saturday and Sunday. However I have the following issues.

It lists the event on each day separately which is ok but it has the end date for each of them as the end date that is set in the date and times. If I don't set an end date it does not show the events.

An event to be displayed this weekend shows the following on it's dates.
Aug. 16, 2014 - Aug. 24, 2020
Aug. 17, 2014 - Aug. 24, 2020

Ideally I'd like each event to list its own dates, so each day of the event this weekend would show Aug. 16, 2014 - Aug. 17, 2014 then the weekend after would show it's own dates.

It may be better if in the settings for recurring events that it had it's own start and end date that is not displayed, to set how long the reoccurring events should be created for and no dates were needed in the "Date and Time" section.

@unclecheese
Copy link
Owner

Can you please replicate the issue on my demo site? http://modules.unclecheeseproductions.com/admin/pages (admin/password)

@Legin76
Copy link
Author

Legin76 commented Aug 15, 2014

I've added a test event with a start and end date for next weekend that should reoccur every weekend.
I can't view it to test though as the page has an error http://modules.unclecheeseproductions.com/calendar/. If it only shows for the one date then a longer end date needs to be set.

@Legin76 Legin76 closed this as completed Aug 15, 2014
@Legin76 Legin76 reopened this Aug 22, 2014
@otiteca
Copy link

otiteca commented Oct 2, 2014

I created a feed on your test site, the ics feed is from google calendar.
Only 1 event is displayed, also there's other events, that are not displayed and they are also recurring events.
In fact event_calendat display only the 1st event from the feed.
For that 1st event, there's a link displayed "Add this to Calendar" is going to 404 not found...

@sekjal
Copy link
Contributor

sekjal commented Feb 26, 2016

Recurring events in ics feeds are not expanded; the RRULE is just not parsed in ICSReader.php.

What about using a different iCal parser, one that can be managed as a dependency with composer? I can't find a version of ICSReader.php hosted by the original author @aidanlister. Using https://github.com/johngrogg/ics-parser, though, we can have recurrences automatically expanded (with exceptions handled) with minimal modification to Calendar::getFeedEvents(). Also, one less local version of a utility file to maintain.

I'd be happy to put together a PR.

@aidanlister
Copy link

Weird that my original seems to have disappeared, I don't remember removing
it. Here's a copy though:

https://github.com/unclecheese/silverstripe-event-calendar/blob/master/code/ICSReader.php
On Sat, 27 Feb 2016 at 7:45 AM, Ian Walls [email protected] wrote:

Recurring events in ics feeds are not expanded; the RRULE is just not
parsed in ICSReader.php.

What about using a different iCal parser, one that can be managed as a
dependency with composer? I can't find a version of ICSReader.php hosted by
the original author @aidanlister https://github.com/aidanlister. Using
https://github.com/johngrogg/ics-parser, though, we can have recurrences
automatically expanded (with exceptions handled) with minimal modification
to Calendar::getFeedEvents(). Also, one less local version of a utility
file to maintain.

I'd be happy to put together a PR.


Reply to this email directly or view it on GitHub
#58 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants