Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readback example is broken #65

Open
divisuals opened this issue Mar 28, 2023 · 3 comments
Open

Readback example is broken #65

divisuals opened this issue Mar 28, 2023 · 3 comments

Comments

@divisuals
Copy link

divisuals commented Mar 28, 2023

The readback example seems to be broken in the latest release.

If you hover over the points, they don't change colors as expected from older examples. Chrome Debug Tools don't show any errors either.

Long-term, would be great to convert such examples as explicit tests.

@divisuals
Copy link
Author

FWIW, I played with older builds/ THREE versions and found this cryptic error in the DevTools:

  • THREE r118.0
  • MathBox v2.2.0 and v2.2.1 (older builds from last year)
WebGLRenderer.js:1275 Uncaught TypeError: material.onBeforeRender is not a function
    at renderObject (WebGLRenderer.js:1275:1)
    at renderObjects (WebGLRenderer.js:1260:1)
    at renderScene (WebGLRenderer.js:1182:1)
    at WebGLRenderer.render (WebGLRenderer.js:1002:1)
    at memo_Memo.render (rendertotexture.js:119:1)
    at readback_Readback.update (readback.js:262:1)
    at Readback.update (readback.js:100:1)
    at Root._trigger (binder.js:121:1)
    at Root.update (root.js:108:1)
    at Context.update (context.js:194:1)

Worth a starting point though this is probably low priority, as there are alternate ways to achieve mouseover effects (Raycaster)

@ChristopherChudzicki
Copy link
Collaborator

Echoing what @sritchie said in #19 (comment), thanks again for reporting these and sorry for inactivity around fixes. (If you are interested in fixing any of these, let us know. Your digging is helpful either way.)

Like sam, I'm a bit busy in recent weeks, but as he said, do let us know if any of these are impacting you seriously.

@divisuals
Copy link
Author

Thanks!

These are not blocking at the moment - I'm just using my ugly, untested workarounds for now.

Will raise issues and create a pull request for any urgent blockers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants